feat(svelte): Add Svelte SDK Package Boilerplate #5535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms-svelte-sdk-boilerplate
branch
from
2636c36
to
0408887
Compare
Lms24
commented
Aug 8, 2022
| "lint": "run-s lint:prettier lint:eslint", | ||
| "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", | ||
| "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"", | ||
| "test": "jest --passWithNoTests", |
There was a problem hiding this comment.
Just added the --passWithNoTests flag so that CI passes until we actually have tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new Svelte SDK boilerplate files for our Svelte Package. It's the first step of setting up a
@sentry/svelteSDK wrapper around the Browser SDK. I figured, I'd split up the boilerplate setup (similarly to Remix in #5256) and adding the actual wrapper (plus a few basic tests) to the SDK. The latter will follow in the next PR after we get this reviewed and merged.Stuff that's currently missing and will be added in follow-up PRs:
Tested not only building but also packaging (
yarn build:npm) and so far everything seems to work pretty well. Will come back to testing this more properly once we have all files in place.ref: #5520