ref(tracing): Record transaction name changes #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
lforst
approved these changes
Sep 12, 2022
Comment on lines
+70
to
73
| /** Setter for `name` property, which also sets `source` as custom */ | ||
| public set name(newName: string) { | ||
| this._name = newName; | ||
| this.metadata.source = 'custom'; | ||
| this.setName(newName); | ||
| } |
There was a problem hiding this comment.
Q: Is there a reason we're maintaining this setter and setName? Always seemed a bit redundant to me.
There was a problem hiding this comment.
to be backwards compatible - we should maybe fix this for v8, will add a todo
size-limit report 📦
|
Base automatically changed from
abhi-transaction-name-change-interface
to
master
September 12, 2022 13:10
AbhiPrasad
force-pushed
the
abhi-record-name-changes
branch
from
0ef9393
to
372b798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5679
Dependent on #5714 merging
This PR makes transaction record name changes internally on the transaction class. This allows for this metadata to be added to outgoing transaction events.