ref(nextjs): Remove redundant pagesDirectory variable in webpack config
#6044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
force-pushed
the
kmclb-nextjs-remove-redundant-pagesDir-variable
branch
from
f74f369
to
2f78802
Compare
lobsterkatie
force-pushed
the
kmclb-nextjs-remove-redundant-pagesDir-variable
branch
from
2f78802
to
2863a7f
Compare
lforst
approved these changes
Oct 27, 2022
lobsterkatie
deleted the
kmclb-nextjs-remove-redundant-pagesDir-variable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
pagesDirectoryvariable in the nextjs SDK'sconstructWebpackConfigFunctionfunction, as its computed value matches that ofpagesDira few lines above, which we read from nextjs config.