Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): Change LCP calculation #7187

Merged
merged 3 commits into from
Feb 16, 2023
Merged

feat(replay): Change LCP calculation #7187

merged 3 commits into from
Feb 16, 2023

Commits on Feb 14, 2023

  1. feat(replay): Change LCP calculation 

    Fixes up calculating LCP timing based on `web-vitals`. Previously we were using the `duration` field on the PerformanceEntry, but it was always 0.

Decided to change the `data.duration` field to `data.value` so that we do not break the frontend when trying to display this new field.
    @billyvg
    billyvg committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e71ef47 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. lint

    @billyvg
    billyvg committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    7f41c8c View commit details
    Browse the repository at this point in the history

  2. fix test

    @billyvg
    billyvg committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a12b0fe View commit details
    Browse the repository at this point in the history