Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replay): Fix timestamps on LCP #7225

Merged
merged 3 commits into from
Feb 23, 2023
Merged

fix(replay): Fix timestamps on LCP #7225

merged 3 commits into from
Feb 23, 2023

Commits on Feb 18, 2023

  1. fix(replay): Fix timestamps on LCP 

    `value` was being used as ms but start/end timestamps are in seconds. Changed start and end to be equal because LCP does not have a duration, it is a single point in time.
    @billyvg
    billyvg committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c8945ed View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. test(replay): Ensure LCP spans have equals start and end timestamps (#… 

    …7229)

(Playwright)
    @Lms24
    Lms24 committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    d21067a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix-replay-fix-timestamps-for-lcp

    @billyvg
    billyvg committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    1f70ff3 View commit details
    Browse the repository at this point in the history