fix(nextjs): Don't crash build when auth token is missing #7427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
reviewed
Mar 13, 2023
| )} environment variable during the build.\n` | ||
| }${ | ||
| process.env.VERCEL | ||
| ? "If you're deploying to Vercel, use the Vercel integration: https://vercel.com/integrations/sentry\n" |
There was a problem hiding this comment.
Suggested change
| ? "If you're deploying to Vercel, use the Vercel integration: https://vercel.com/integrations/sentry\n" | |
| ? "If you're deploying to Vercel, use the Vercel integration to automatically set a Sentry auth token: https://vercel.com/integrations/sentry\n" |
Should we even show the above lines if we are on Vercel? It should be enough to just say, hey set the Vercel integration, thats all you need to do.
There was a problem hiding this comment.
Good suggestion: c86e63c Thanks!
lforst
force-pushed
the
lforst-dont-crash-on-missing-auth-token-and-print-log-msg
branch
from
55eef6f
to
c86e63c
Compare
lforst
deleted the
lforst-dont-crash-on-missing-auth-token-and-print-log-msg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents Next.js builds from crashing during source maps upload when building and instead prints an error message that gives instructions on how to configure the auth token.
Because the webpack config is invoked 3 times, the message will show up 3 times. I will leave this up for a future fix.