Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): Bring back finishReason for interaction transactions #7449

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

0Calories
Copy link
Contributor

@0Calories 0Calories commented Mar 13, 2023

There are several interaction transactions in production that have no spans at all, and we want to find out why this is the case.

This PR reintroduces finishReason from e0f9ca0 but only sets it as a tag for interaction transactions.

This is only temporary, this tag will allow us to diagnose the reason for why interaction transactions appear to be ending early, or without any data. We can remove it from the SDK once we've finished investigating.

Here's an example of one of these strange transactions:
image

@0Calories 0Calories requested review from k-fish, AbhiPrasad, a team and Lms24 and removed request for a team March 13, 2023 20:30
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.25 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 62.98 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.88 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 55.89 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.64 KB (0%)
@sentry/browser - Webpack (minified) 67.41 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.66 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.66 KB (+0.23% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.62 KB (+0.37% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.87 KB (+0.38% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.17 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.19 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.29 KB (+0.16% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 54.37 KB (0%)

@0Calories 0Calories self-assigned this Mar 13, 2023
@AbhiPrasad AbhiPrasad merged commit 8343eb0 into develop Mar 14, 2023
@AbhiPrasad AbhiPrasad deleted the feat/track-finishReason-for-interactions branch March 14, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants