Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(sveltekit): Remove vite types from build output #7480

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 16, 2023

In #7438, we added vite.config.ts to our SvelteKit pacakge. We also added it to our sveltekit/tsconfig.json instead of sveltekit/tsconfig.test.json which meant that some types from Vite ended up in our sveltekt/build/types directory.This messed up the directory structure and causing the types entry point to no longer be valid. This PR fixes that by adding the vite config to tsconfig.test.json.

Also, this PR fixes the test:unit yarn script as just executing vitest started vitest in watch mode on local machines (and single-run mode on CI). IMO we shouldn't start it in watch mode by default, as we have test:unit:watch to do that.

@Lms24 Lms24 requested a review from AbhiPrasad March 16, 2023 11:29
@Lms24 Lms24 self-assigned this Mar 16, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.41 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 63.3 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.99 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.21 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.65 KB (0%)
@sentry/browser - Webpack (minified) 67.44 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.68 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.12 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 33.66 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.01 KB (+0.05% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.17 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 37.19 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.31 KB (+0.02% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 54.39 KB (+0.01% 🔺)

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@Lms24 Lms24 merged commit dd40b46 into develop Mar 16, 2023
@Lms24 Lms24 deleted the lms/sveltekit-fix-vitest-setup branch March 16, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants