build(sveltekit): Remove vite
types from build output
#7480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7438, we added
vite.config.ts
to our SvelteKit pacakge. We also added it to oursveltekit/tsconfig.json
instead ofsveltekit/tsconfig.test.json
which meant that some types from Vite ended up in oursveltekt/build/types
directory.This messed up the directory structure and causing the types entry point to no longer be valid. This PR fixes that by adding the vite config totsconfig.test.json
.Also, this PR fixes the
test:unit
yarn script as just executingvitest
started vitest in watch mode on local machines (and single-run mode on CI). IMO we shouldn't start it in watch mode by default, as we havetest:unit:watch
to do that.