build: Use setup node instead of volta action #7763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team and
lforst
and removed request for
a team
|
Q: Does that also use the volta pinned yarn version? Or do we need to make sure this is the correct one? |
lforst
approved these changes
Apr 6, 2023
It seems action/setup-node have yarn pre-installed to a certain version. As per the docs, this is Yarn 1.22.19, what we have hard pinned via volta. |
mydea
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file,
actions/setup-nodewill use thevoltadefinition for node version - so we should be ably to safely switch away from volta.Closes #7690