Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Extract error tree walking logic for LinkedErrors integrations #8455

Merged
merged 6 commits into from
Jul 5, 2023
Merged

ref: Extract error tree walking logic for LinkedErrors integrations #8455

merged 6 commits into from
Jul 5, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Jul 5, 2023 •
edited

Ref: #5469

Extracts the Error tree walking logic out of the two LinkedErrors integrations (node, browser) into the utils package.
Also adds a bit more streamlined tests for that function and removes the tests for the integrations because they were essentially just duplicated.

@lforst lforst changed the title ref: Exctract error tree walking logic for LinkedErrors integration ref: Exctract error tree walking logic for LinkedErrors integrations Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.81 KB (+0.08% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 68.56 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.11 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 59.81 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.73 KB (+0.1% 🔺)
@sentry/browser - Webpack (minified) 70.94 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.75 KB (+0.09% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.22 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 29.77 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 27.83 KB (+0.04% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.42 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 43.1 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.21 KB (+0.03% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.67 KB (+0.02% 🔺)

@lforst lforst force-pushed the lforst-unify-linked-errors branch from 1598a7a to 91beac3 Compare July 5, 2023 11:00
mydea
mydea approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@lforst lforst marked this pull request as ready for review July 5, 2023 16:04
@AbhiPrasad AbhiPrasad changed the title ref: Exctract error tree walking logic for LinkedErrors integrations ref: Extract error tree walking logic for LinkedErrors integrations Jul 5, 2023
@lforst lforst enabled auto-merge (squash) July 5, 2023 16:27
@lforst lforst merged commit 1d8c81f into develop Jul 5, 2023
66 checks passed
@lforst lforst deleted the lforst-unify-linked-errors branch July 5, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lforst @mydea @AbhiPrasad