Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Avoid importing SentryWebpackPlugin in dev mode #8557

Merged
merged 1 commit into from
Jul 17, 2023

Commits on Jul 17, 2023

  1. fix(nextjs): Avoid importing SentryWebpackPlugin in dev mode (#8543)

    As reported in #8541, our NextJS SDK currently breaks dev mode for the
    newest NextJS 13.4.10 version
    
    I have absolutely no idea which of the changes in
    [13.4.10](https://github.com/vercel/next.js/releases/tag/v13.4.10) is
    causing this.
    However, I traced the error back and it happens as soon as our NextJS
    SDK package requires @sentry/webpack-plugin:
    
    * @sentry/nextjs calls `require('@sentry/webpack-plugin')`
    * @sentry/webpack-plugin calls `const { RawSource } =
    require('webpack-sources');`
    * For _whatever_ reason, NextJS can't require `webpack-sources` and
    throws 馃挜
    
    Since we don't enable our Webpack plugin [in dev
    mode](https://github.com/getsentry/sentry-javascript/blob/723f851f358b75cd39da353804c51ff27ebb0c11/packages/nextjs/src/config/webpack.ts#L305)
    anyway, one way to get rid of this error is to only require it if we're
    _not_ in dev mode.
    
    This hotfix therefore moves the top-level require of
    `@sentry/webpack-plugin` to a dynamic require. This isn't a great
    solution and honestly quite ugly but if it unblocks users for now I'd
    say we merge it. I think we should definitely revisit this though once
    we know more about why NextJS suddenly isn't able to import
    `webpack-sources`.
    
    ref #8541
    Lms24 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    68a0e13 View commit details
    Browse the repository at this point in the history