Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextjs): Check for existence of default export when wrapping pages #8794

Merged
merged 2 commits into from
Aug 11, 2023
Merged

fix(nextjs): Check for existence of default export when wrapping pages #8794

merged 2 commits into from
Aug 11, 2023

Commits on Aug 11, 2023

  1. fix(nextjs): Check for existence of default export when wrapping pages 

    Fixes #8792

In #8792 a user reports that we read `getInitialProps` from `undefined`. The only place where we read `getInitialProps` is in the page wrapper template. As a fix we simply check for its existence before accessing the field.
    @lforst
    lforst committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    26f04e1 View commit details
    Browse the repository at this point in the history

  2. No nullish coalesce

    @lforst
    lforst committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f134045 View commit details
    Browse the repository at this point in the history