Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): Move common node ANR code to utils #9191

Merged

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Oct 6, 2023

This PR moves common ANR code to utils so it can be used for Electron renderer ANR detection.

watchdogTimer

Moved to utils with the addition of an enabled flag which isn't used in node

createDebugPauseMessageHandler

Handles messages from the debugger protocol.

  • Collects script ids for later filename lookups
  • Collects, converts and passes stack frames to a callback when the debugger pauses
  • Now uses stripSentryFramesAndReverse to remove Sentry frames!

@timfish timfish marked this pull request as ready for review October 6, 2023 15:01
packages/utils/src/anr.ts Outdated Show resolved Hide resolved
@AbhiPrasad AbhiPrasad changed the title feat(electron): Move common ANR code to utils feat(utils): Move common node ANR code to utils Oct 11, 2023
@AbhiPrasad AbhiPrasad merged commit 729e432 into getsentry:develop Oct 11, 2023
69 checks passed
@timfish timfish deleted the feat/electron-move-common-anr-code branch October 11, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants