fix(utils): Avoid keeping a reference of last used event #9387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
approved these changes
Oct 27, 2023
mydea
force-pushed
the
fn/event-avoid-reference
branch
from
65a2081
to
7d5f366
Compare
mydea
commented
Oct 30, 2023
| @@ -131,6 +131,9 @@ export function makeTerserPlugin() { | |||
| '_meta', | |||
| // Object we inject debug IDs into with bundler plugins | |||
| '_sentryDebugIds', | |||
| // These are used by instrument.ts in utils for identifying HTML elements & events | |||
| '_sentryCaptured', | |||
There was a problem hiding this comment.
good thing we have good integration tests, that captured this! We also forgot this for _sentryCaptured (I guess we have no integration test covering this), so I also added this here @lforst
lforst
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed some time ago, this changes the dom instrumentation to avoid keeping any reference to an event in the module scope.
Instead, we put a
_sentryIdnon-enumerable property on the event target (if possible) and check based on this.I also added some tests to verify the expected behavior, also for future changes here.
Fixes #9204