Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move LinkedErrors integration to @sentry/core #9404

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Oct 27, 2023

  • Remove LinkedErrors from Node SDK and use Core SDK LinkedErrors instead
  • Use LinkedErrors integration in Vercel Edge SDK
  • Update Deno SDK to use LinkedErrors integration from Core instead of Browser

In a future PR I'm going to remove browser specific LinkedErrors integration and make everything rely on implementation in Core SDK.

This refactor came from two places

  1. We noticed the Deno SDK relies on the browser SDK. This is not ideal, so this helps with that
  2. We got feedback via customer that LinkedErrors was not available in @sentry/vercel-edge

- Remove LinkedErrors from Node SDK and use Core SDK LinkedErrors
  instead
- Use LinkedErrors integration in Vercel Edge SDK
- Update Deno SDK to use LinkedErrors integration from Core instead of
  Browser
@AbhiPrasad AbhiPrasad requested review from a team, lforst and Lms24 and removed request for a team October 27, 2023 21:13
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 77.43 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 66.49 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.97 KB (0%)
@sentry/browser - Webpack (gzipped) 21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.79 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.09 KB (+0.45% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.23 KB (+0.48% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 216.85 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.28 KB (+0.5% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.28 KB (+0.7% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.8 KB (+0.19% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 77.82 KB (0%)
@sentry/react - Webpack (gzipped) 21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 94.15 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 47.86 KB (0%)

@AbhiPrasad AbhiPrasad self-assigned this Oct 27, 2023
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!
(also I'm wondering why we had different integrations for browser and Node in the first place)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) October 30, 2023 16:13
@AbhiPrasad AbhiPrasad merged commit 89a4d42 into develop Oct 30, 2023
87 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-linked-errors-in-core branch October 30, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants