Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Update prisma span to be db.prisma #9512

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

AbhiPrasad
Copy link
Member

Prisma can be used for NoSQL dbs like mongo, so change the span op from db.sql.prisma to db.prisma

Prisma can be used for NoSQL dbs like mongo, so change the span op from
`db.sql.prisma` to `db.prisma`
@AbhiPrasad AbhiPrasad requested review from a team, mydea and stephanie-anderson and removed request for a team November 9, 2023 16:00
Copy link
Contributor

github-actions bot commented Nov 9, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.33 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 55.57 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.98 KB (0%)
@sentry/browser - Webpack (gzipped) 21.3 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 61.9 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.1 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.24 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 195.23 KB (+0.17% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.32 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.3 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.81 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.69 KB (+0.12% 🔺)
@sentry/react - Webpack (gzipped) 21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.42 KB (+0.09% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.13 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 15.98 KB (0%)

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made me think, do we need to also set op on the otel spans probably 🤔*not for this pr but something to keep in mind!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) November 9, 2023 16:53
@AbhiPrasad AbhiPrasad merged commit 49b9ec3 into develop Nov 9, 2023
87 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-prisma-op branch November 9, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants