-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(remix): Rework Error Handling #9725
Merged
AbhiPrasad
merged 6 commits into
develop
from
onur/remix-captureRemixServerException-rework
Dec 5, 2023
Merged
ref(remix): Rework Error Handling #9725
AbhiPrasad
merged 6 commits into
develop
from
onur/remix-captureRemixServerException-rework
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
1155a1b
to
1f076b6
Compare
1f076b6
to
453d1c4
Compare
captureRemixServerException
AbhiPrasad
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for these changes @onurtemizkan!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #9695
Should also resolve: #9563
Rewrote the error reporting logic of Remix SDK to handle inconsistencies, missing stack traces and potential duplications.
There are 5 main error types that we are concerned.
loader
s andactions
And there are different points we can capture such as:
handleError
,action / loader / documentRequest
instrumentationErrorBoundary
An error is not guaranteed to end up only one of those utilities. Also the objects for the same error are not guaranteed to be the same in different places. That causes duplications.
So, with this patch, the new error handling / filtering logic for the instrumentation will be as below:
handleError
loader
/action
InstrumentationdocumentRequest
InstrumentationErrorBoundary
@sentry/react
ErrorBoundary
loader
/action
ErrorsThis PR also adds:
Sentry.wrapRemixHandleError
to be assigned ashandleError
forentry.server
(Needs docs / wizard support)