Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Ensure withScope sets current scope correctly with async callbacks #9974

Merged
merged 2 commits into from
Dec 22, 2023
Merged

fix(core): Ensure withScope sets current scope correctly with async callbacks #9974

merged 2 commits into from
Dec 22, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 22, 2023

Oops, I noticed that our current withScope implementation does not actually wait for async callbacks for setting the current scope 😬 Related to #9958, which I copied there now!

@mydea mydea requested review from lforst and Lms24 December 22, 2023 13:01
@mydea mydea self-assigned this Dec 22, 2023
@mydea mydea changed the title fix(core): Ensure withScope works with async callbacks fix(core): Ensure withScope sets current scope correctly with async callbacks Dec 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.92 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 67.29 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.91 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.86 KB (+0.11% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.42 KB (+0.11% 🔺)
@sentry/browser - Webpack (gzipped) 22.12 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 73.34 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 65 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 31.15 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.15 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 203.87 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 93.76 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 68.69 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 34.11 KB (+0.13% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.7 KB (+0.05% 🔺)
@sentry/react - Webpack (gzipped) 22.16 KB (+0.16% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 84.34 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.98 KB (+0.07% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.63 KB (+0.19% 🔺)

@mydea mydea enabled auto-merge (squash) December 22, 2023 14:29
@mydea mydea merged commit 2c0b6d3 into develop Dec 22, 2023
95 checks passed
@mydea mydea deleted the fn/withScope branch December 22, 2023 14:30
anonrig pushed a commit that referenced this pull request Jan 3, 2024
@mydea @anonrig
fix(core): Ensure withScope sets current scope correctly with async…
0704d38 
… callbacks (#9974)

Oops, I noticed that our current `withScope` implementation does not
actually wait for async callbacks for setting the current scope 😬
Related to #9958,
which I copied there now!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mydea @lforst