Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: change payload type of replay event #265

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 29, 2024

Previously, we were using a unoptimized data structure. This change makes sure that we don't break production and also make the transition to a better one.

Ref: getsentry/snuba#5831
Ref: getsentry/sentry#69916

Copy link

github-actions bot commented Apr 29, 2024

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

  • getsentry/snuba: pip:sentry-kafka-schemas==0.1.72 (upgrade)
  • getsentry/snuba: rust:sentry-kafka-schemas==0.1.72 (upgrade)
  • getsentry/sentry: pip:sentry-kafka-schemas==0.1.74

latest version: 0.1.74

benign changes

schemas/ingest-replay-events.v1.schema.json

  • {"path": ".payload", "change": {"TypeAdd": {"added": "string"}}}
    
  • {"path": ".payload", "change": {"TypeAdd": {"added": "number"}}}
    
  • {"path": ".payload", "change": {"TypeAdd": {"added": "integer"}}}
    
  • {"path": ".payload", "change": {"TypeAdd": {"added": "object"}}}
    
  • {"path": ".payload", "change": {"TypeAdd": {"added": "boolean"}}}
    
  • {"path": ".payload", "change": {"TypeAdd": {"added": "null"}}}
    

✅ This PR should be safe to roll out to consumers first. Make sure to bump
the library in the following repos first:

getsentry/snuba
getsentry/super-big-consumers

...then in the other repos:

getsentry/sentry

Take a look at the README for how to release a new version of sentry-kafka-schemas.

@anonrig anonrig force-pushed the anonrig/change-payload-type branch from 755a059 to 93d5148 Compare April 29, 2024 21:28
@anonrig anonrig merged commit 39acc37 into main Apr 29, 2024
13 checks passed
@anonrig anonrig deleted the anonrig/change-payload-type branch April 29, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants