Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kmp demo #71

Closed
wants to merge 17 commits into from
Closed

feat: kmp demo #71

wants to merge 17 commits into from

Conversation

buenaflor
Copy link
Contributor

Add additional KMP demo that can be used for the kotlinconf

includes:

  • Koin dependency injection
  • ViewModels

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- kmp demo ([#71](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/71))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 00dc7cd


### Android
- Export your `ANDROID_HOME` environment variable if you haven't done already.
- You can run `./gradlew :sentry-samples:kmp-app:androidApp:assembleDebug` to compile the Android app.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- You can run `./gradlew :sentry-samples:kmp-app:androidApp:assembleDebug` to compile the Android app.
- You can run `./gradlew :sentry-samples:kmp-app:androidApp:assembleDebug` to compile the Android app.
- You can run `xcodebuild -workspace ./sentry-samples/kmp-app-mvvm-di/iosApp/iosApp.xcworkspace -scheme iosApp -configuration Debug -sdk iphonesimulator -arch arm64` to compile the iOS app.

@marandaneto
Copy link
Contributor

@marandaneto
Copy link
Contributor

@buenaflor So at the end of the day this didn't work at all for iOS, I tried myself but could not figure it out quickly.
Would you mind taking a stab and making it green on CI? I probably face the same errors as CI.

@buenaflor
Copy link
Contributor Author

Yeah I'll take a look at it

@buenaflor
Copy link
Contributor Author

added in #82

@buenaflor buenaflor closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants