Fix generated route name not correctly detected when using prefixes

[wfeller]

Use Str::contains instead of Str::startsWith to verify if route name is generated.

Fixes #440

[stayallive]

Hey @wfeller I have been testing this but I don't see this problem occurring...

I am testing on Laravel 8, which version are you using?

When using the route below and running php artisan route:cache I get: generated::FRnHID1MBC9OnhFk and not test.generated::FRnHID1MBC9OnhFk.

Route::group([
    'name' => 'test.',
], function () {
	Route::view('test', 'home');
})

[wfeller]

We're on Laravel 8.23.1

Try it with this maybe - I think the name argument doesn't do the same thing as prefix:

Route::prefix('prefix.')->group(function () {
    Route::view('test', 'home');
});

From my Sentry performance tab:

[stayallive]

I don't think this does what I think it would do...

Route::prefix('pizza.')->group(function () {
    Route::view('test', 'home');
});

This generates the route: app.develop/pizza./test, I don't think that is what you intended?

Below generates the route: app.develop/test as I would expect.

Route::name('pizza.')->group(function () {
    Route::view('test', 'home');
});

Maybe I'm totally missing the boat here and you mean to use the prefix that way but I don't think that's right.

But even with that inspecting my bootstrap/cache/routes-v7.php I cannot get Laravel to generate the prefix before the generated name :(

[wfeller]

My bad, I looked at my routes file and saw prefix first, thought it had to be it! (we actually use both prefix and as)

I can reproduce it in a fresh Laravel codebase:

Route::as('prefix.')->group(function () {
    Route::get('test-1', 'Controller@action');
    Route::get('test-2', 'Controller@action');
});

This will generate 2 cached routes:
"prefix.": /test-1
"prefix.generated::U282gBpR9Z1vbfVc": /test-2

It doesn't seem possible to reproduce the issue with only 1 unnamed route.

[stayallive]

Yep that did it! Sorry about the many questions just wanted to make sure this was needed.

Thank you for your patience, I hope to release this in the next week.