Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to the artisan sentry:publish command to better support --no-interaction mode #509

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

vokamut
Copy link
Contributor

@vokamut vokamut commented Aug 2, 2021

No description provided.

@stayallive
Copy link
Collaborator

stayallive commented Aug 2, 2021

Why did you go for {--disable-performance-monitoring} {--without-test}?

Wouldn't it make more sense and be clearer to go for something like:

{--performance-monitoring : Also configure performance monitoring.} 
{--test : Test the Sentry integration after setup.}

Running php artisan sentry:publish --dsn=... --performance-monitoring --test seems more clear to me that next to publishing it adds performance monitoring config and runs a config test then running php artisan sentry:publish --dsn=... and it doing extra things you did not ask for? Do you agree?

@vokamut
Copy link
Contributor Author

vokamut commented Aug 2, 2021

Because the default values will change

@stayallive stayallive changed the title Adding flags for quiet mode application Add options to the artisan sentry:publish command to better support --no-interaction mode Aug 2, 2021
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep you are right, better to keept the same defaults :)

Thanks for this, I only changed the name of the performance monitoring option to be more clear IMHO.

@stayallive stayallive merged commit 0538b91 into getsentry:master Aug 2, 2021
@vokamut vokamut deleted the patch-1 branch August 2, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants