Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_exceptions & ignore_transactions to the default config #802

Merged
merged 3 commits into from Nov 22, 2023

Conversation

smknstd
Copy link
Contributor

@smknstd smknstd commented Nov 20, 2023

Hello,

As getsentry/sentry-php#1503 aimed to make ignoring exceptions "dead simple", I guess it should be included by default in the config file. Then it would be a lot easier to learn about the feature instead of searching into the doc (which is incomplete at the moment).

@cleptric cleptric changed the title add empty ignore_exceptions to the config by default Add ignore_exceptions & ignore_transactions to the default config Nov 20, 2023
@cleptric
Copy link
Member

Docs are in the making. Can you add some comments above the added options, please?

config/sentry.php Outdated Show resolved Hide resolved
@smknstd
Copy link
Contributor Author

smknstd commented Nov 20, 2023

done !

Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've opted to comment them out by default, docs are being worked on! Thanks!

@cleptric
Copy link
Member

Docs are merged, getsentry/sentry-docs#8552.

@cleptric cleptric merged commit 38ccc3a into getsentry:master Nov 22, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants