Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel Lumen performance traces not collected because route never matched #822

Merged
merged 3 commits into from Jan 16, 2024
Merged

Laravel Lumen performance traces not collected because route never matched #822

merged 3 commits into from Jan 16, 2024

Conversation

summerKK
Copy link
Contributor

@summerKK summerKK commented Dec 20, 2023 •
edited by stayallive

Fixes #821.

@stayallive stayallive self-assigned this Dec 21, 2023
@stayallive stayallive changed the title fix: lumen tracing cannot be reported. Laravel Lumen performance traces not collected because route never matched Dec 21, 2023
stayallive
stayallive approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to logic to what we had before we started using the event to detect if a route was matched and moved it to a helper for clearer code and made sure missing routes are still traced also for Lumen. Thanks for taking the time to report and submit a PR!

@stayallive stayallive linked an issue Dec 21, 2023 that may be closed by this pull request
Lumen does not have the Illuminate\Routing\Events\RouteMatched event. #821
Closed
@summerKK summerKK mentioned this pull request Dec 22, 2023
Closed
@stayallive stayallive merged commit 129c0b3 into getsentry:master Jan 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

@cleptric cleptric cleptric approved these changes

Assignees

@stayallive stayallive

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lumen does not have the Illuminate\Routing\Events\RouteMatched event.
3 participants
@summerKK @stayallive @cleptric