fix: Avoid manipulating config when resolving disks #901
Conversation
This commit updates the storage integration such that it does not manipulate the filesystems config when a disk is resolved. This fixes an issue when using scoped disks where the disk's prefix property was injected into the parent disk's config, making the parent disk unusable from that point forward.
|
Seeing that the CI failed I now understand why the hack was added in the first place: The |
|
It would be nice if scoped disks will work correctly of course but we should also make sure that it works for all Laravel versions of course. So I'm happy to see if you can find a workable workaround to make this work for all supported versions. Edit: I marked it as draft for now, feel free to mark as ready whenever of course 👍 |
|
The only solutions I can think of are to copy the I'm not sure if there is any willingness to include either of those options. What do you think, @stayallive? |
|
Pushed a commit that should work with all Laravel versions without using reflection or copying code from the Laravel repository. Kudos to @grEvenX who came up with the solution. |
This commit updates the storage integration such that it does not manipulate the filesystems config when a disk is resolved.
Doing so fixes an issue when using scoped disks where the disk's prefix property is injected into the parent disk's config, making the parent disk unusable from that point forward.
The added test doesn't replicate the issue with scoped disks specifically because the
league/flysystem-path-prefixingpackage is required to use scoped disks. The best I could do was to assert that the config isn't being manipulated when a disk is resolved, which seems sensible in and of itself.Tagging you here, @spawnia, as you may have some insight into why the "hack" this commit removes was added in the first place, and if it's still needed (ref #726).