Allow setting CRASHPAD_WER_ENABLED when using system crashpad (#816)

getsentry · Mar 13, 2023 · 903c17a · 903c17a
1 parent 1f14ef0
commit 903c17a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 - Remove OpenSSL as direct dependency for the crashpad backend on Linux. ([#812](https://github.com/getsentry/sentry-native/pull/812), [crashpad#81](https://github.com/getsentry/crashpad/pull/81))
 - Check `libcurl` for feature `AsynchDNS` at compile- and runtime. ([#813](https://github.com/getsentry/sentry-native/pull/813))
+- Allow setting `CRASHPAD_WER_ENABLED` when using system crashpad. ([#816](https://github.com/getsentry/sentry-native/pull/816))
 
 ## 0.6.0
 

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -426,8 +426,9 @@ if(SENTRY_BACKEND_CRASHPAD)
 			set(CRASHPAD_ENABLE_INSTALL ON CACHE BOOL "Enable crashpad installation" FORCE)
 		endif()
 		add_subdirectory(external/crashpad crashpad_build)
+
 		if(CRASHPAD_WER_ENABLED)
-			add_compile_definitions(CRASHPAD_WER_ENABLED)
+			add_dependencies(sentry crashpad::wer)
 		endif()
 
 		# set static runtime if enabled
@@ -482,8 +483,9 @@ if(SENTRY_BACKEND_CRASHPAD)
 		endif()
 	endif()
 	add_dependencies(sentry crashpad::handler)
+
 	if(CRASHPAD_WER_ENABLED)
-		add_dependencies(sentry crashpad::wer)
+		add_compile_definitions(CRASHPAD_WER_ENABLED)
 	endif()
 elseif(SENTRY_BACKEND_BREAKPAD)
 	option(SENTRY_BREAKPAD_SYSTEM "Use system breakpad" OFF)