Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing SENTRY_SDK_NAME at runtime #821

Closed
marandaneto opened this issue Mar 20, 2023 · 0 comments · Fixed by #834
Closed

Allow changing SENTRY_SDK_NAME at runtime #821

marandaneto opened this issue Mar 20, 2023 · 0 comments · Fixed by #834
Assignees

Comments

@marandaneto
Copy link
Contributor

marandaneto commented Mar 20, 2023

The build pipeline already considers the SENTRY_SDK_NAME config at compile time.
Ideally, the SDK is able to change its name at runtime.

#ifndef SENTRY_SDK_NAME
# ifdef __ANDROID__
# define SENTRY_SDK_NAME "sentry.native.android"
# else
# define SENTRY_SDK_NAME "sentry.native"
# endif
#endif

For example:
sentry_set_sdk_name(...) or sentry_options_set_sdk_name(...), some SDKs have it under the options while this attribute is internal/private but allow Hybrid SDKs to do it anyway.
Context getsentry/sentry-dart#1333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants