Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NDK from sentry-java to sentry-native #944

Merged
merged 16 commits into from
May 22, 2024
Merged

Conversation

markushi
Copy link
Member

@markushi markushi commented Feb 5, 2024

Relevant sentry-java PR: getsentry/sentry-java#3189

Copy link

github-actions bot commented Feb 5, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a083163

@markushi markushi changed the title PoC: Move NDK from sentry-java to sentry-native Move NDK from sentry-java to sentry-native Apr 29, 2024
@markushi markushi marked this pull request as ready for review May 3, 2024 09:19
@supervacuus
Copy link
Collaborator

The failing Android builds (oh, the irony) are due to new log output from the emulator and are unrelated to this PR.

Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, @markushi, thanks for the effort. I cannot tell you how happy this makes me.

I already wrote my first instrumented test with this setup:

> Task :sentry-native-ndk:connectedDebugAndroidTest
Starting 1 tests on Pixel 6a - 14
Connected to process 21635 on device 'google-pixel_6a-36021JEGR17254'.

This will significantly help in probing certain aspects, especially evaluating different approaches.

LGTM, if this works on your side, then I see nothing stopping me from merging this. I only have minor questions.

ndk/build.gradle.kts Show resolved Hide resolved
ndk/detekt.yml Outdated Show resolved Hide resolved
ndk/build.gradle.kts Show resolved Hide resolved
ndk/lib/build.gradle.kts Outdated Show resolved Hide resolved
@supervacuus supervacuus merged commit 6544650 into master May 22, 2024
20 checks passed
@supervacuus supervacuus deleted the feat/integrate-jni branch May 22, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants