-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move NDK from sentry-java to sentry-native #944
Conversation
|
The failing Android builds (oh, the irony) are due to new log output from the emulator and are unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG, @markushi, thanks for the effort. I cannot tell you how happy this makes me.
I already wrote my first instrumented test with this setup:
> Task :sentry-native-ndk:connectedDebugAndroidTest
Starting 1 tests on Pixel 6a - 14
Connected to process 21635 on device 'google-pixel_6a-36021JEGR17254'.
This will significantly help in probing certain aspects, especially evaluating different approaches.
LGTM, if this works on your side, then I see nothing stopping me from merging this. I only have minor questions.
Relevant
sentry-java
PR: getsentry/sentry-java#3189