(PHP 8) Stacktrace with frames referring to anonymous classes are not grouped together

[toemat]

Hi! I found this issue while trying to figure out why my events have not been grouped lately. I think PHP 8 changed the syntax of these anonymous class lines from {file}0x{mem} to {file}:{line}${mem}

PHP 7.x: class@anonymous/home/test.php0x7f76c7628065
PHP 8.x: class@anonymous/home/test.php:3$3e0a7

This seems to be the regex to remove the 0x style address, maybe adjust to match either 0x{hex} OR ${hex}?

sentry-php/src/FrameBuilder.php

Line 79 in 64b9696

$functionName = sprintf('%s::%s', preg_replace('/0x[a-fA-F0-9]+$/', '', $functionName), $backtraceFrame['function']);

So /0x[a-fA-F0-9]+$/ to /(\$|0x)[a-fA-F0-9]+$/

Does it seem like I'm on the right track? I can open a PR if that's best.

[ste93cry]

Does it seem like I'm on the right track?

You are, indeed. I found that the change of the string format was done in php/php-src#0f2cdbf to fix a bug

I can open a PR if that's best.

It would be very welcome 😃

[stayallive]

Thanks for reporting and fixing it 💪

---

This has been resolved by #1315 and will be released shortly!