You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Based on your documentation breadcrumbs support the level debug, info, warning, error and fatal (see screenshot).
But the Breadcrumb class has a constant with the value critical, which is part of the allowed levels array (instead of a fatal level), which is also used for validation in the constructor (Breadcrumb.php#L64).
This issue causes confusion and conflict when translating PSR3 log levels to sentry breadcrumb levels. In addition neither the level critical nor the level fatal have special highlighting on a sentry exception. Only warning and error status receive a meaningful styling.
Please clearify which is now correct, critical or fatal. Either way please update the documentation and/or the php sdk. If fatal is the correct one, I would suggest adding the correct constant and deprecating the critical one.
The text was updated successfully, but these errors were encountered:
* #901: Replace critical with fatal status
Critical breadcrumb status is not supported. Replaced it with fatal.
* Consistent deprecation comment
Use consistent deprecation comment.
Co-Authored-By: Alessandro Lai <alessandro.lai85@gmail.com>
* #901: Update CHANGELOG.md
Based on your documentation breadcrumbs support the level
debug
,info
,warning
,error
andfatal
(see screenshot).But the Breadcrumb class has a constant with the value
critical
, which is part of the allowed levels array (instead of a fatal level), which is also used for validation in the constructor (Breadcrumb.php#L64).This issue causes confusion and conflict when translating PSR3 log levels to sentry breadcrumb levels. In addition neither the level
critical
nor the levelfatal
have special highlighting on a sentry exception. Onlywarning
anderror
status receive a meaningful styling.Please clearify which is now correct,
critical
orfatal
. Either way please update the documentation and/or the php sdk. Iffatal
is the correct one, I would suggest adding the correct constant and deprecating thecritical
one.The text was updated successfully, but these errors were encountered: