Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid breadcrumb level #901

Closed
TheLevti opened this issue Oct 15, 2019 · 0 comments · Fixed by #902
Closed

Invalid breadcrumb level #901

TheLevti opened this issue Oct 15, 2019 · 0 comments · Fixed by #902
Milestone

Comments

@TheLevti
Copy link
Contributor

TheLevti commented Oct 15, 2019

Based on your documentation breadcrumbs support the level debug, info, warning, error and fatal (see screenshot).

image

But the Breadcrumb class has a constant with the value critical, which is part of the allowed levels array (instead of a fatal level), which is also used for validation in the constructor (Breadcrumb.php#L64).

This issue causes confusion and conflict when translating PSR3 log levels to sentry breadcrumb levels. In addition neither the level critical nor the level fatal have special highlighting on a sentry exception. Only warning and error status receive a meaningful styling.

Please clearify which is now correct, critical or fatal. Either way please update the documentation and/or the php sdk. If fatal is the correct one, I would suggest adding the correct constant and deprecating the critical one.

@ste93cry ste93cry added this to the 2.2 milestone Oct 15, 2019
Jean85 pushed a commit that referenced this issue Oct 17, 2019
* #901: Replace critical with fatal status

Critical breadcrumb status is not supported. Replaced it with fatal.

* Consistent deprecation comment

Use consistent deprecation comment.

Co-Authored-By: Alessandro Lai <alessandro.lai85@gmail.com>

* #901: Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants