Cleanup the Monolog handler from deprecated features #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
requested changes
Aug 19, 2020
Totally agree, but is it really something to write in the UPGRADE file or would it be better in official doc? |
ste93cry
force-pushed
the
feature/cleanup-monolog-handler
branch
from
455bcef
to
3f26aba
Compare
Jean85
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I'm going to revert the support of our Monolog handler for setting tags and extras on the events. The reason of this change is that, as discussed multiple times in the past, we don't want to rely on pulling more information than necessary from the unstructured data of the record's context because the same keys may be used by the user for things that have nothing to do with Sentry