Add named constructors to the Event class #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
force-pushed
the
feature/add-named-constructors-to-event-class
branch
from
d65ef99
to
5106bf6
Compare
Jean85
approved these changes
Sep 11, 2020
stayallive
approved these changes
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little (breaking) change in the
Eventclass: since we now have two types of events (event and transaction), I decided to add named constructors and make the default constructorprivate. This should make it easier in the future to encapsulate the minimum amount of information required for initializing each type of event and ensure that the newly created object is in a valid and consistent state from the beginning rather than rely on the hope that users will call all the appropriate setters depending on the situation