Only accept Event on captureEvent methods #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
requested changes
Sep 24, 2020
stayallive
force-pushed
the
cleanup-capture-event
branch
2 times, most recently
from
c6ccfdf
to
66bcac9
Compare
ste93cry
requested changes
Sep 24, 2020
stayallive
force-pushed
the
cleanup-capture-event
branch
2 times, most recently
from
9f0a685
to
9368b24
Compare
ste93cry
approved these changes
Sep 25, 2020
stayallive
force-pushed
the
cleanup-capture-event
branch
from
bd157f4
to
a96b9e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EventHint class was introduced to pass around extra data needed to correctly hydrate an event, this method of "hinting" was copied from the JavaScript SDK.
Chosen for a dedicated class to have type safety built-in instead of having an array and adding type checks and isset everywhere, this looks cleaner internally. To make it easier to use I've added a simple
fromArraystatic method to have "the best of both worlds" I think, if users need it they can use theextraproperty on the hint to add arbitrary data.