Fix error_reporting value not evaluated on the moment of the error being reported by default
#1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
changed the title
error_reporting value not evaluated on the moment of the error being reported by default
Jean85
reviewed
Mar 11, 2021
tests/phpt/error_handler_respects_current_error_reporting_level.phpt
Outdated
Show resolved
Hide resolved
Jean85
requested changes
Mar 11, 2021
Jean85
approved these changes
Mar 11, 2021
ste93cry
requested changes
Mar 11, 2021
ste93cry
approved these changes
Mar 24, 2021
|
@ste93cry Do you have any prediction on when this will be tagged and released? |
|
Released right now as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a bug where
error_reporting()is copied on initialisation of the SDK and not evaluated on the moment of the error capture.There are 2 changed to the behaviour of the SDK after this bug fix:
error_typesoption on the SDK theerror_reporting()value is used to determine if an error should be reported to Sentry@operator are reported regardless of their level, only takingcapture_silenced_errors(defaults tofalse) into considerationThe last point is a side effect (IMO perfectly acceptable) because we cannot know the actual error reporting level while handling silenced (by the
@operator) errors because PHP temporarily modifies theerror_reporting()level while handling such errors.Fixes #1195.