Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to ignore errors from a specific tag #1201

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Add option to ignore errors from a specific tag #1201

merged 1 commit into from
Mar 18, 2021

Conversation

VincentLanglet
Copy link
Contributor

No description provided.

@VincentLanglet VincentLanglet mentioned this pull request Mar 17, 2021
Closed
ste93cry
ste93cry requested changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@ste93cry ste93cry left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Can you please also add a CHANGELOG entry?

EDIT
This feature should target the develop branch, can you please make the switch and rebase accordingly?

tests/Integration/IgnoreErrorsIntegrationTest.php Outdated Show resolved Hide resolved
tests/Integration/IgnoreErrorsIntegrationTest.php Outdated Show resolved Hide resolved
@ste93cry ste93cry added this to the 3.3 milestone Mar 17, 2021
@VincentLanglet VincentLanglet changed the base branch from master to develop March 17, 2021 12:28
@VincentLanglet
Copy link
Contributor Author

Done @ste93cry :)

ste93cry
ste93cry requested changes Mar 17, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ste93cry ste93cry requested a review from Jean85 March 17, 2021 17:31
ste93cry
ste93cry approved these changes Mar 18, 2021
View reviewed changes
Copy link
Collaborator

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🎉

@ste93cry ste93cry merged commit 69da9c4 into getsentry:develop Mar 18, 2021
@VincentLanglet VincentLanglet deleted the ignoreTags branch March 18, 2021 08:59
@VincentLanglet
Copy link
Contributor Author

@ste93cry You're welcome.

What is the release strategy of this package ? :)
Just to have an idea about how much time I'll have to wait for this feature

@ste93cry
Copy link
Collaborator

We have no real strategy, we accumulate some things and when we think we have enough features for a new minor version we release it. Sadly, I don't have any ETA for when this may happen though

@VincentLanglet
Copy link
Contributor Author

It's been two month, a new minor release would be really appreciate if it is possible :)

@ste93cry
Copy link
Collaborator

Release 3.3.0 is out 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ste93cry ste93cry ste93cry approved these changes

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
Type: Feature
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VincentLanglet @ste93cry @Jean85