Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing frames's arguments when calling captureEvent() without explicit stacktrace or exception #1223

Merged

Conversation

ste93cry
Copy link
Collaborator

Fixes #1220 by removing the DEBUG_BACKTRACE_IGNORE_ARGS constant from the call to the debug_backtrace() function. I think I've used it to lower the memory usage, however it makes sense to collect these information.

…()` without expliciting a stacktrace or an exception
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 so this would impact only manual capturing or captureMessage with attach_stacktrace === true?

@ste93cry
Copy link
Collaborator Author

Exactly 😉

@ste93cry ste93cry merged commit a6e3d6e into master Jun 18, 2021
@ste93cry ste93cry deleted the fix/frame-arguments-missing-when-calling-capture-event branch June 18, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local variables are not showing on stack trace
2 participants