Fix overwriting of the event's error level set by the user when capturing an ErrorException exception
#1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring an ErrorException exception
Jean85
requested changes
Oct 19, 2021
stayallive
approved these changes
Oct 19, 2021
Jean85
approved these changes
Oct 22, 2021
Jean85
deleted the
fix/event-log-level-overridden-by-exception-severity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1248: when a user set the error level on the event, we should not override it with the severity taken from the
ErrorExceptionexception. While fixing the bug, I also noticed that the tests were faulty because we were using the same instance of the event for both the input and the output, making the test always pass regardless of the expectations