Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minor to include fix for composer #9816 #1267

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Bump minor to include fix for composer #9816 #1267

merged 1 commit into from
Nov 30, 2021

Conversation

99linesofcode
Copy link
Contributor

@99linesofcode 99linesofcode commented Nov 30, 2021 •
edited

Didn't run the tests yet. Hoping that CI will catch any boo boo's.

Composer https://github.com/composer/composer/releases/tag/2.0.14 introduced a breaking change to something that pretty-package-versions depends on. They fixed it in their 2.0.4 release. See:

Jean85/pretty-package-versions#39

@99linesofcode
Copy link
Contributor Author

sentry-laravel will also need to be updated to incorporate these changes. Is that on your radar already?

Jean85
Jean85 approved these changes Nov 30, 2021
View reviewed changes
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ste93cry
Copy link
Collaborator

Thinking more about this, I have two questions:

  • @Jean85, why your package doesn't require the minimum version of Composer that prevents the issue, forcing this package instead to require it?
  • @99linesofcode, why should we update sentry-laravel? That package depends on this one, so once we release this change the Laravel users will benefit from it in cascade

@ste93cry
Copy link
Collaborator

@Jean85, why your package doesn't require the minimum version of Composer that prevents the issue, forcing this package instead to require it?

I will answer myself to this question: because the issue was not with Composer itself but with your package. I misread the package name in the composer.json and thought that 2.0.4 was the version of Composer. Sorry, long day today 🤯

@ste93cry ste93cry added this to the 3.3 milestone Nov 30, 2021
@ste93cry ste93cry merged commit ea3dca1 into getsentry:master Nov 30, 2021
@99linesofcode 99linesofcode deleted the fix-pretty-package-versions-composer-deprecation branch November 30, 2021 23:03
@Jean85
Copy link
Collaborator

Jean85 commented Dec 1, 2021

sentry-laravel will also need to be updated to incorporate these changes. Is that on your radar already?

Does it? I don't think it uses anything directly, it's this base SDK that does everything, so it should be fixed without further intervention.

@99linesofcode
Copy link
Contributor Author

Does it? I don't think it uses anything directly, it's this base SDK that does everything, so it should be fixed without further intervention.

Yeah my bad. I thought maybe we had to bump the sentry/sdk version but of course its version range constrained 👍

Thanks for the quick 1-2 guys!

@99linesofcode
Copy link
Contributor Author

99linesofcode commented Dec 27, 2021 •
edited

@ste93cry could it be that we still need to tag this in order for packagist to pick up on it properly? 🎅🎄

@Jean85
Copy link
Collaborator

Jean85 commented Dec 27, 2021

This is not tagged yet, yes, but you can apply the same constraint to your projects as a workaround for now.

@ste93cry
Copy link
Collaborator

Ops you're right, I completely forgot to release it 🤦‍♂️ Done now with version 3.3.5

Jean85 added a commit that referenced this pull request Jan 13, 2022
@Jean85 @99linesofcode
@ste93cry @vladanpaunovic
Merge master into develop (#1275)
baf9653 
* Bump the minimum required version of `jean85/pretty-package-versions` (#1267)

* Prepare release `3.3.5`

* Update PHPStan, Psalm and PHP-CS-Fixer to the latest versions (#1272)

* Update PHP-CS-Fixer

* Update PHPStan

* Update Psalm

* Raise PHPStan level to 9

* Run PHP-CS-Fixer on the latest stable PHP version

* Fix code style

* Fix Psalm type definition and update PHPStan baseline

* Relax Composer constraint about PHP-CS-Fixer and make it run on PHP `8.1`

* Update PHPStan baseline

* meta(gha): Deploy action stale.yml (#1259)

* Reduce PSalm baseline

Co-authored-by: J. Schreuders <3071062+99linesofcode@users.noreply.github.com>
Co-authored-by: Stefano Arlandini <sarlandini@alice.it>
Co-authored-by: Vladan Paunovic <vladan.paunovic.bg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ste93cry ste93cry ste93cry approved these changes

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
Type: Improvement
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@99linesofcode @ste93cry @Jean85