Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add setter for type on ExceptionDataBag #1347

Merged
merged 4 commits into from
Aug 17, 2022
Merged

feat: Add setter for type on ExceptionDataBag #1347

merged 4 commits into from
Aug 17, 2022

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Aug 17, 2022 •
edited

This will allow users to set the type of exception at a later stage.
As mentioned in #1100, I didn't add any tests here.

Closes #1338

@cleptric cleptric self-assigned this Aug 17, 2022
@vladanpaunovic vladanpaunovic linked an issue Aug 17, 2022 that may be closed by this pull request
Expose exception severity in data bag #1338
Closed
stayallive
stayallive approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@cleptric cleptric merged commit 1289e7c into develop Aug 17, 2022
@cleptric cleptric deleted the mh/data-bag-set-type branch August 17, 2022 13:20
@cleptric cleptric added this to the 3.8 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

Assignees

@cleptric cleptric

Labels
Type: Feature
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.

Expose exception severity in data bag
2 participants
@cleptric @stayallive