Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Do not register the error handler if the DSN is null #1349

Merged
merged 4 commits into from
Aug 19, 2022
Merged

ref: Do not register the error handler if the DSN is null #1349

merged 4 commits into from
Aug 19, 2022

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Aug 17, 2022 •
edited

Closes #1190

@cleptric cleptric self-assigned this Aug 17, 2022
@cleptric cleptric linked an issue Aug 17, 2022 that may be closed by this pull request
Do not register the error handler if the DSN is null #1190
Closed
stayallive
stayallive approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to me! 👍

@cleptric
Copy link
Member Author

@ste93cry Thanks for the feedback. I only noticed your branch after I finished this, sadly.

ste93cry
ste93cry approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to treat it as a bugfix, we can merge in master and release it earlier. Please also set the labels and milestones so that we keep track of what ends up in which version

@cleptric cleptric added this to the 3.8 milestone Aug 18, 2022
@cleptric
Copy link
Member Author

cleptric commented Aug 18, 2022 •
edited

I would say this is an improvement, so let's put this into 3.8. I also think this isn't anything urgent.

@cleptric cleptric merged commit 39fa647 into develop Aug 19, 2022
@cleptric cleptric deleted the mh/error-handler branch August 19, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

@ste93cry ste93cry ste93cry approved these changes

@Jean85 Jean85 Awaiting requested review from Jean85

Assignees

@cleptric cleptric

Labels
Type: Improvement
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.

Do not register the error handler if the DSN is null
3 participants
@cleptric @stayallive @ste93cry