feat: Add tracePropagationTargets option #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleptric
force-pushed
the
trace-propagation-targets
branch
from
c7b3ed0
to
750f15b
Compare
stayallive
approved these changes
Oct 4, 2022
absumo
added a commit
to sumocoders/application-skeleton
that referenced
this pull request
Sep 19, 2023
Sending the baggage header might result in errors from external APIs and can potentially leak private data. This limits the trace_propagation_targets to only the current domain. An empty array (the default when not set) is treated as all hosts are allow listed. See this PR for additional info: getsentry/sentry-php#1396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not break people's usage of the
GuzzleTracingMiddleware, I only check fortracePropagationTargetswhen applying thebaggageheader.Also nothing fancy here, a simple array with an allow-list of hosts.
Closes #1395 & #1361