Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isTracingEnabled instead of getEnableTracing #1555

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Use isTracingEnabled instead of getEnableTracing #1555

merged 1 commit into from
Jun 23, 2023

Conversation

cleptric
Copy link
Member

The newly added functions (getBaggage(), getTraceparent() and continueTrace()) are checking the wrong option to check if tracing is enabled.

Updated the tests as enable_tracing does not surface this.

@cleptric cleptric self-assigned this Jun 23, 2023
@cleptric cleptric requested a review from stayallive June 23, 2023 21:53
@cleptric cleptric merged commit b311b54 into master Jun 23, 2023
29 checks passed
@cleptric cleptric deleted the use-correct-option branch June 23, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

Assignees

@cleptric cleptric

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cleptric @stayallive