[2.0] Array recursive scrubbing #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nokitakaze
reviewed
Jun 21, 2018
| @@ -193,6 +192,36 @@ public function processDataProvider() | |||
| ], | |||
| ], | |||
| ], | |||
| [ | |||
| [ | |||
| 'extra_context' => [ | |||
There was a problem hiding this comment.
Please add test with depth 2 or 3. So we could see the method are working with deep depth.
nokitakaze
approved these changes
Jun 22, 2018
|
@stayallive @ste93cry or anyone else, can you review? |
ste93cry
approved these changes
Jul 19, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the last incomplete test on the 2.0 branch, porting #212 and addressing #145.