Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mark Sentry internal frames for attach_stacktrace to in_app false #786

Merged
merged 3 commits into from Mar 6, 2019
Merged

fix: Mark Sentry internal frames for attach_stacktrace to in_app false #786

merged 3 commits into from Mar 6, 2019

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Mar 5, 2019

This marks Sentry internal frames when using attach_stacktrace to in_app false to have better grouping and stack trace.

Before:
image

After:
image

@HazAT HazAT self-assigned this Mar 5, 2019
stayallive
stayallive approved these changes Mar 5, 2019
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

ste93cry
ste93cry requested changes Mar 5, 2019
View reviewed changes
tests/ClientTest.php Outdated Show resolved Hide resolved
@HazAT HazAT requested a review from ste93cry March 5, 2019 18:29
@ste93cry ste93cry added this to the 2.0 milestone Mar 5, 2019
Jean85
Jean85 requested changes Mar 5, 2019
View reviewed changes
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, we forgot to update the changelog!

@HazAT HazAT merged commit 3388504 into master Mar 6, 2019
@HazAT HazAT deleted the fix/attach_stacktrace-mark-inapp branch March 6, 2019 16:39
@Jean85 Jean85 mentioned this pull request Mar 25, 2019
Merged
@ste93cry ste93cry mentioned this pull request May 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 requested changes

@stayallive stayallive stayallive approved these changes

@ste93cry ste93cry ste93cry approved these changes

Assignees

@HazAT HazAT

Labels
Type: Improvement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HazAT @stayallive @ste93cry @Jean85