Fix Client::captureEvent not considering the attach_stacktrace option #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamasSzigeti
approved these changes
Dec 20, 2019
Jean85
requested changes
Dec 20, 2019
Jean85
approved these changes
Dec 20, 2019
ste93cry
force-pushed
the
fix/939-capture-event-ignores-attach-stacktrace-option
branch
5 times, most recently
from
19e973e
to
a5a3c0f
Compare
ste93cry
force-pushed
the
fix/939-capture-event-ignores-attach-stacktrace-option
branch
from
a5a3c0f
to
fd53add
Compare
ste93cry
force-pushed
the
fix/939-capture-event-ignores-attach-stacktrace-option
branch
from
1134aee
to
49c3d67
Compare
ste93cry
deleted the
fix/939-capture-event-ignores-attach-stacktrace-option
branch
because if you don't do it, the sentry.io web service won't display the backtrace of the captured exception but instead the backtrace to where you called See #957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #939: the
Client::captureEventmethod should consider theattach_stacktrace, instead it doesn't (it was done on purpose for some reason because there was a test for this, but I cannot remember/understand why we chose like that)