Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace zendframework/zend-diactoros with guzzlehttp/psr7 #945

Merged
merged 2 commits into from
Jan 1, 2020
Merged

Replace zendframework/zend-diactoros with guzzlehttp/psr7 #945

merged 2 commits into from
Jan 1, 2020

Conversation

DeyV
Copy link
Contributor

@DeyV DeyV commented Dec 31, 2019

Move from zendframework/zend-diactoros to guzzlehttp/psr7

ste93cry
ste93cry requested changes Dec 31, 2019
View reviewed changes
Copy link
Collaborator

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the hard work. Just one note though for the future: there is no need to close the old PR and open an entirely new one to target a different branch, just use the Edit button at the top of the page and then rebase on top of the new branch

tests/Fixtures/code/BrokenClass.php Outdated Show resolved Hide resolved
tests/Integration/RequestIntegrationTest.php Outdated Show resolved Hide resolved
@ste93cry ste93cry requested a review from Jean85 December 31, 2019 10:51
@ste93cry ste93cry added this to the 2.3 milestone Dec 31, 2019
@ste93cry ste93cry changed the title Zend framework is in stagnation. guzzlehttp/psr7 Replace zendframework/zend-diactoros with guzzlehttp/psr7 Dec 31, 2019
@DeyV
Copy link
Contributor Author

DeyV commented Dec 31, 2019

Thank you for the hard work. Just one note though for the future: there is no need to close the old PR and open an entirely new one to target a different branch, just use the Edit button at the top of the page and then rebase on top of the new branch

thx- I forgot about this possibility

@DeyV DeyV requested a review from ste93cry December 31, 2019 11:51
@stayallive stayallive merged commit 37db676 into getsentry:develop Jan 1, 2020
@ste93cry ste93cry mentioned this pull request Jan 2, 2020
Closed
This was referenced Jan 2, 2020
Closed
Closed
Jean85 added a commit that referenced this pull request Jan 3, 2020
@Jean85
Update CHANGELOG.md
a359326 
Add changelog entry for #945
@mitchhentges mitchhentges mentioned this pull request Mar 5, 2020
Closed
@Jean85 Jean85 mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

@ste93cry ste93cry ste93cry approved these changes

@Jean85 Jean85 Awaiting requested review from Jean85

Assignees
No one assigned
Labels
Type: Improvement
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DeyV @stayallive @ste93cry