Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

feat(vsts): Add Visual Studio extension #232

Merged
merged 1 commit into from Sep 15, 2017
Merged

feat(vsts): Add Visual Studio extension #232

merged 1 commit into from Sep 15, 2017

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Sep 13, 2017

Add basic VSTS integration using refactored components from JIRA, GitHub, and Asana. Also update LICENSES to be more correct. Currently it is limited to the 'Create Issue' action.

Fixes getsentry/sentry#5263

See also boylec/sentry-vsts#5

@dcramer dcramer force-pushed the vsts/import branch 6 times, most recently from 6bc822a to 5f90daf Compare September 13, 2017 21:44
@dcramer
Copy link
Member Author

dcramer commented Sep 13, 2017

Actually I'm going to implement OAuth before we do this

https://www.visualstudio.com/en-us/docs/integrate/get-started/authentication/oauth

@ghost
Copy link

ghost commented Sep 13, 2017

1 Error
🚫 Do not modify the License
2 Warnings
⚠️ Changes to build requirements
⚠️ You should update CHANGES due to the size of this PR

Generated by 🚫 Danger

@dcramer
Copy link
Member Author

dcramer commented Sep 13, 2017

getsentry/sentry#6124

@dcramer
Copy link
Member Author

dcramer commented Sep 14, 2017

Would be great to follow up and add a basic repository provider. May not have webhooks, but we can always on-demand scrape commits when a release is created.

https://www.visualstudio.com/en-us/docs/integrate/api/git/overview

@dcramer dcramer changed the title feat(vsts): Add VSTS extension feat(vsts): Add Visual Studio extension Sep 14, 2017
@dcramer
Copy link
Member Author

dcramer commented Sep 14, 2017

Still some more cleanup, but in a good spot now.

  • Uses OAuth for credentials (via linked changeset)
  • Uses standard utilities for API calls and response handling

In the future we should:

  • Add select of account/project to the create issue form
  • Add 'Link Issue' action

@dcramer
Copy link
Member Author

dcramer commented Sep 14, 2017

I also standardized a bunch of the redundant API client code, and we could probably re-use it for most if not all of the integrations to greatly trim down on semi-broken behavior.

@dcramer
Copy link
Member Author

dcramer commented Sep 14, 2017

making a few more changes to future proof this

@dcramer dcramer force-pushed the vsts/import branch 4 times, most recently from 57e15ba to 329484b Compare September 14, 2017 22:41
@dcramer
Copy link
Member Author

dcramer commented Sep 14, 2017

  • Removed fixed project
  • Added link issue
  • Future proofed things for on-premise installs, changing instance, etc

http://i.cra.mr/2V2X3L2t0I1E

@dcramer
Copy link
Member Author

dcramer commented Sep 14, 2017

@macqueen ok rebased this though I will also do a review of the github changes now just in case i messed up something during the merge

Add basic VSTS integration using refactored components from JIRA, GitHub, and Asana.
@dcramer dcramer merged commit e1d8307 into master Sep 15, 2017
@dcramer dcramer deleted the vsts/import branch September 15, 2017 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants