Skip to content

Commit

Permalink
docs(tracing): Delete inaccurate comment
Browse files Browse the repository at this point in the history
`sampled` being set to `False` is not the only reason why the `_span_recorder` might be `None`. Another explanation is that the transaction was not started via `start_transaction`.
  • Loading branch information
szokeasaurusrex committed Apr 25, 2024
1 parent 6a73368 commit bda9deb
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion sentry_sdk/tracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,6 @@ def finish(self, hub=None, end_timestamp=None):
# We have no active client and therefore nowhere to send this transaction.
return None

# This is a de facto proxy for checking if sampled = False
if self._span_recorder is None:
logger.debug("Discarding transaction because sampled = False")

Expand Down

0 comments on commit bda9deb

Please sign in to comment.