Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry Python SDK does not support Apache Beam 2.33 #1231

Closed
thaddock opened this issue Oct 28, 2021 · 8 comments
Closed

Sentry Python SDK does not support Apache Beam 2.33 #1231

thaddock opened this issue Oct 28, 2021 · 8 comments
Labels
Help wanted Extra attention is needed Type: Bug Something isn't working

Comments

@thaddock
Copy link

Environment

self-hosted (onpremise deployment)

Version

1.4.3

Steps to Reproduce

  1. Add Sentry with BeamIntegration to an Apache Beam 2.33 pipeline, for instance:
        sentry_sdk.init(
            dsn=os.environ.get("SENTRY_DSN"),
            release=os.environ.get("SENTRY_RELEASE", "unidentified release"),
            environment=os.environ.get("SENTRY_ENVIRONMENT", "unidentified environment"),
            integrations=[BeamIntegration()],
            before_send=before_send
        )
  1. Run the pipeline

Expected Result

Expected Pipeline to run successfully, and errors reported to Sentry.

Actual Result

Received this error:

Traceback (most recent call last):
  (traceback from our code)
  File "/usr/local/lib/python3.7/site-packages/sentry_sdk/hub.py", line 105, in _init
    client = Client(*args, **kwargs)  # type: ignore
  File "/usr/local/lib/python3.7/site-packages/sentry_sdk/client.py", line 86, in __init__
    self._init_impl()
  File "/usr/local/lib/python3.7/site-packages/sentry_sdk/client.py", line 124, in _init_impl
    "auto_enabling_integrations"
  File "/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/__init__.py", line 120, in setup_integrations
    type(integration).setup_once()
  File "/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/beam.py", line 49, in setup_once
    _wrap_inspect_call(DoFn, func_name),
  File "/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/beam.py", line 83, in _wrap_inspect_call
    from apache_beam.typehints.decorators import getfullargspec  # type: ignore
ImportError: cannot import name 'getfullargspec' from 'apache_beam.typehints.decorators' (/usr/local/lib/python3.7/site-packages/apache_beam/typehints/decorators.py)
@thaddock
Copy link
Author

thaddock commented Oct 28, 2021

Note, I can also reproduce this in the test suite, by install the usual dependencies, and running:

pip install apache-beam==2.33
pytest tests/integrations/beam

I think this problem started with Apache Beam 2.30

@getsentry-release
Copy link

Routing to @getsentry/team-webplatform for triage. ⏲️

@chadwhitacre chadwhitacre transferred this issue from getsentry/sentry Oct 28, 2021
@AbhiPrasad AbhiPrasad added Type: Bug Something isn't working Help wanted Extra attention is needed Status: Backlog labels Oct 28, 2021
galuszkak pushed a commit to FlyrInc/sentry-python that referenced this issue Oct 29, 2021
@galuszkak
Copy link
Contributor

Hey,

I've prepared fix in #1233.

galuszkak pushed a commit to FlyrInc/sentry-python that referenced this issue Oct 29, 2021
galuszkak pushed a commit to FlyrInc/sentry-python that referenced this issue Oct 29, 2021
AbhiPrasad pushed a commit that referenced this issue Nov 4, 2021
Co-authored-by: Kamil Gałuszka <galuszkak@FVFGC0XHQ05P.local>
@galuszkak
Copy link
Contributor

galuszkak commented Nov 9, 2021

Hey @AbhiPrasad @chadwhitacre ,

Do we know when fix in #1233 will be released? We just want to know some preliminary time to align our release process .

Thanks

@chadwhitacre
Copy link
Member

Hey, @galuszkak! Great to see you here! 👋 😀 And thanks for the PR! ☺️

I'm a bit out of the loop on sentry-python release cadence. Hopefully @AbhiPrasad can shed some light?

@AbhiPrasad
Copy link
Member

We are blocked by getsentry/craft#322 + failing tests in master (though there is a fix at #1212). The moment that those two get resolved, we will cut a release and let you know.

@chadwhitacre
Copy link
Member

Thanks @AbhiPrasad. Looks like you are on #1212. 👍 getsentry/craft#322 looks like the bigger issue ...

@AbhiPrasad
Copy link
Member

Fix released as part of SDK version 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Extra attention is needed Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants