Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster Tests (DjangoCon) #1602

Merged
merged 82 commits into from
Sep 19, 2022
Merged

Faster Tests (DjangoCon) #1602

merged 82 commits into from
Sep 19, 2022

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Sep 6, 2022 •
edited
Loading

This fixes #1499

  • Trying the sentry-ruby way (splitting up into multiple yaml files, this works great. I have created a script to split tox.ini into multiple yaml files automatically)
  • Trying tox-gh (does not help us, because we already have this paralleization in GitHub actions)
  • Cleaning up the yaml file in general.
  • Using a RAM drive for the tox virtualenvs in the GitHub runners
  • Removed PyPy from the test suite because it was never run. We have to reevaluate support for PyPy.

@antonpirker
Trying tox-gh
bbfbb94
@antonpirker
Splitting out django tests
4723dd7
@antonpirker
Better name
88dce73
@antonpirker
Tailored matrix
d2cd775
@antonpirker
Better naming
14094c8
@antonpirker
Fixed naming
c59b679
@antonpirker
Matrix stuff
ed2f8b4
@antonpirker
Matrix stuff 2
daeaa8a
@antonpirker
Cleanup
0d2c0e7
@antonpirker
Fixed include matric
95da9da
@antonpirker
Actually try to run the tests again.
d3958a9
@antonpirker
Better call to tox
59c8f79
@antonpirker
Removed some Django versions
fb99fa1
@antonpirker
Trying new matrix format
f04133d
@antonpirker
Fixed python version string
b3f5137
@antonpirker
Fixed matrix again
1af02c3
@antonpirker
Cleanup
4d7ce29
@antonpirker
Cleanup Django test environments definistion
a51f12d
@antonpirker
Fixed pypy definition
d8d4143
@antonpirker
First splitting everything
ecbce4a
@antonpirker
Fixed typo
b5729e2
@antonpirker
Try to get nice env name
9fc5f72
@antonpirker
Fixed typo
bea6a1b
@antonpirker
Regenerated file
e9abdbf
@antonpirker
Reactivated tests
27a5184
@antonpirker
Fixed shell var unpacking
dbfeb34
@antonpirker
All the new config files
977de5a
@antonpirker
Deactivate redis/postgres everywhere to see where it is not needed.
3967317
@antonpirker
Regenerate github actions config
d42134d
@antonpirker
Removed setup-node
9cee517
@antonpirker antonpirker changed the title Test experiments Faster Tests (DjangoCon) Sep 15, 2022
@antonpirker antonpirker marked this pull request as ready for review September 16, 2022 12:04
antonpirker
antonpirker commented Sep 16, 2022
View reviewed changes
tox.ini Show resolved Hide resolved
sl0thentr0py
sl0thentr0py requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok firstly, great work!
just some random comments and one more here.

Can you document in the PR description / contributing guide what we need to do if we add/remove a certain tox configuration in tox.ini? (basically just run the script again, I guess.)

.github/workflows/test-common.yml Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
sl0thentr0py
sl0thentr0py approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@antonpirker
Copy link
Member Author

I have now made it so the CI fails when tox.ini and the existing yaml files are out of sync: https://github.com/getsentry/sentry-python/actions/runs/3082611176/jobs/4982524192

@antonpirker antonpirker merged commit f5ee56b into master Sep 19, 2022
@antonpirker antonpirker deleted the antonpirker/tests-experiments branch September 19, 2022 14:40
@rominf rominf mentioned this pull request Jul 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run test suite in under 10 minutes
2 participants
@antonpirker @sl0thentr0py